K8SPG-637: disable restore on pg-restore deletion
#950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooknull
requested review from
egegunes,
hors and
inelpandzic
as code owners
pooknull
requested review from
eleo007,
jvpasinatto,
nmarukovich,
ptankov and
tplavcic
as code owners
egegunes
previously approved these changes
Dec 11, 2024
inelpandzic
reviewed
Dec 12, 2024
Contributor
inelpandzic
left a comment
inelpandzic
left a comment
There was a problem hiding this comment.
@pooknull pls check these tests
inelpandzic
previously approved these changes
Dec 20, 2024
hors
reviewed
Dec 31, 2024
Collaborator
hors
left a comment
hors
left a comment
There was a problem hiding this comment.
We have the same issue with backups as well. I will create separate task to fix it.
gkech
previously approved these changes
Jan 17, 2025
gkech
previously approved these changes
Jan 20, 2025
egegunes
reviewed
Jan 21, 2025
Comment on lines
551
to
554
| if checkBackupJob(job) != v2.BackupSucceeded { | ||
| if err := c.Delete(ctx, job); err != nil { | ||
| return nil, errors.Wrap(err, "delete pg-backup job") | ||
| } |
Contributor
There was a problem hiding this comment.
why do we delete the backup job?
Contributor
There was a problem hiding this comment.
deleting job might make debugging hard for users
egegunes
previously approved these changes
Jan 22, 2025
gkech
previously approved these changes
Jan 22, 2025
gkech
approved these changes
Jan 23, 2025
Collaborator
commit: f21b507 |
egegunes
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPG-637
DESCRIPTION
Problem:
If user deletes
pg-restorebefore it fails or succeeds, the operator doesn't remove.spec.backup.restorefrompg.Solution:
Add the
percona.com/delete-restorefinalizer to the newpg-restoreobjects, which will remove the required section on deletion ofpg-restoreif it didn't fail or succeed.This PR also fixes
K8SPG-700, by addingpercona.com/delete-backupfinalizer to the newpg-backupobjects. This finalizer will delete backup annotations from cr.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability